search

rust-lang / jobserver-rs

Apache License 2.0
69 stars 39 forks source link

fix: remove preadv2 optimization #88

Closed weihanglo closed 4 months ago

weihanglo commented 4 months ago

This optimization has introduced many compatibility issues, so remove it for now until we find it worthy the investment.

See also

the8472 commented 4 months ago

You can use libc::syscall(SYS_preadv2, ...) to invoke the function without direct glibc support. If the kernel doesn't support it you'll get ENOSYS as usual.

weihanglo commented 4 months ago

Thanks! That sounds also correct, though I personally don't have time investing in it (also have less experience of that). Need somebody else to work on that route.

ofek commented 4 months ago

If it's not a one or two line change then I agree that we should revert for now to fix builds. I would be interested in the syscall change however because that seems simple but I'm not familiar with the code base.

ofek commented 4 months ago

When might this be released?

NobodyXu commented 4 months ago

I've asked @petrochenkov to do so on zulip, only they have the right to publish a new release