rust-lang / lang-team

Home of the Rust lang team
http://lang-team.rust-lang.org/
Apache License 2.0
200 stars 48 forks source link

Add size != stride to frequently requested changes #216

Closed carbotaniuman closed 11 months ago

joshtriplett commented 1 year ago

Could you add some language here explaining the implications for objects that set their alignment greater than their size would normally be?

joshtriplett commented 1 year ago

@rfcbot merge

rfcbot commented 1 year ago

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. See this document for info about what commands tagged team members can give me.

pnkfelix commented 1 year ago

Should we consider cross-referencing the other discussions that the project has had on this topic, if only to make it easier for people reading these docs to find past discussions about the matter?

I'm thinking specifically of:

RalfJung commented 1 year ago

There's also https://github.com/rust-lang/unsafe-code-guidelines/issues/176.

nikomatsakis commented 1 year ago

@rfcbot reviewed

rfcbot commented 1 year ago

:bell: This is now entering its final comment period, as per the review above. :bell:

rfcbot commented 1 year ago

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.