Open my4ng opened 1 month ago
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.
Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review
and S-waiting-on-author
) stays updated, invoking these commands when appropriate:
@rustbot author
: the review is finished, PR author should check the comments and take action accordingly@rustbot review
: the author is ready for a review, this PR will be queued again in the reviewer's queue
This PR adds some missing netfilter constants from:
linux/netfilter.h
linux/netfilter_arp.h
linux/netfilter_bridge.h
linux/netfilter_ipv4.h
linux/netfilter_ipv6.h
Unresolved questions:
NF_NETDEV_NUMHOOKS
andNF_NETDEV_INGRESS
were not moved fromsemver/linux-gnu.txt
tosemver/linux.txt
during #2152. Should that be rectified now?NF_NETDEV_NUMHOOKS
value was changed from 1 to 2 in linux kernel 5.16 (https://github.com/torvalds/linux/commit/42df6e1d221dddc0f2acf2be37e68d553ad65f96) and hence some workaround was added tolibc_test/build.rs
: https://github.com/rust-lang/libc/blob/acc7bb1a38e2b9d6a18f28279d80d464c4c25089/libc-test/build.rs#L1842 https://github.com/rust-lang/libc/blob/acc7bb1a38e2b9d6a18f28279d80d464c4c25089/libc-test/build.rs#L3940 Is it OK to chnage them to 2 now and remove those lines or do we have to maintain some level of backwards-compatibility?NF_IP_PRI_RAW_BEFORE_DEFRAG
introduced in 5.10?