rust-lang / libc

Raw bindings to platform APIs for Rust
https://docs.rs/libc
Apache License 2.0
2.1k stars 1.04k forks source link

ci: Ensure build channels get run even if FILTER is unset #4125

Closed tgross35 closed 2 days ago

tgross35 commented 2 days ago

In 59a18de777("ci: Set -u (error on unset)..."), -u started being passed to the set call in shell scripts. This broke the FILTER logic since now the command always fails.

Make this a bit less fragile by explicitly setting to an empty string, as well as adding a check that at least one test got run.

rustbot commented 2 days ago

r? @JohnTitor

rustbot has assigned @JohnTitor. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer