port newlib's cosf - Githubissues

japaric commented 6 years ago

Source 1: https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;a=blob;f=newlib/libm/math/sf_cos.c;hb=HEAD

Source 2: https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;a=blob;f=newlib/libm/mathfp/sf_sine.c;hb=HEAD

(Unsure which one we want.)

Rationale: the current implementation makes use of f64 and it has bad performance on architectures that have no hardware support for double precision floats.

What needs to be done:

Move the existing MUSL port into a private math::musl module and make sure we continue compiling it.
Port the newlib version into src/math/$fun.rs
Update the test suite by uncommenting the function name in tests/newlib.rs and removing the function name from tests/musl.rs.

rrbutani commented 6 years ago

~Working on this one.~

japaric commented 6 years ago

PR #141 implements this

jordens commented 3 years ago

Short status summary on this and #138:

141 has been closed.
In general we don't want the mathfp impl as it's inaccurate and unmaintained/unused in newlib

rust-lang / libm

port newlib's cosf #135

141 has been closed.