search

rust-lang / libm

A port of MUSL's libm to Rust.
Other
540 stars 98 forks source link

Remove unneeded `extern core` in `tgamma` #289

Closed Amjad50 closed 8 months ago

Amjad50 commented 8 months ago

This was causing some issues when building the crate for different targets that don't have core builtin.

Amjad50 commented 8 months ago

Closed because of #290

Amanieu commented 8 months ago

I think this can be merged if you re-open it. You can also fix the CI issues by just allowing the internal features warning.

Amjad50 commented 8 months ago

Alright, I reopened this now. I'll probably close the other PR #290 if weak symbols are a better approach.

For the CI errors, I'm assuming it's unrelated to this PR.

Amanieu commented 8 months ago

CI should be fixed, can you rebase?

Amjad50 commented 8 months ago

Thanks @Amanieu