search

rust-lang / libz-sys

Rust crate package to link to a system libz (zlib)
Apache License 2.0
110 stars 73 forks source link

fix #149 #150

Closed secext2022 closed 10 months ago

secext2022 commented 10 months ago

fix build for aarch64-linux-android

https://github.com/rust-lang/libz-sys/issues/149

Byron commented 10 months ago

Thanks a lot for submitting the PR. It looks like CI is happy. Would you be able to change the CI setup to include the aarch64-linux-android target?

secext2022 commented 10 months ago

It seems that test with cross for android is error, so only build for android in CI.

Byron commented 10 months ago

The android tests look like they passed, and the other failures are spurious so I restarted them. Once CI is green, could you do me a favour and unapply/revert the first commit temporarily so we see the android tests failing? That way we would validate that the android runs are actually catching the issue, which would mean that we will be warned of such issues in future as well.

Thanks a lot for your help.

secext2022 commented 10 months ago

Sorry, I made a mistake.

CI should test build libz-ng-sys but was build libz-sys.

secext2022 commented 10 months ago

It seems that test in CI not work. I'm trying to figure out why.

secext2022 commented 10 months ago

Sorry, this is not a BUG of libz-ng-sys, it is my mistake. I will explain this in detail in #149.