search

rust-lang / log

Logging implementation for Rust
https://docs.rs/log
Apache License 2.0
2.19k stars 253 forks source link

set_logger doc improvements #135

Closed alexcrichton closed 7 years ago

alexcrichton commented 7 years ago
alexcrichton commented 7 years ago

We should also clarify the error conditions here to mention there's no memory unsafety, but also clearly state what the error conditions are.

rap2hpoutre commented 7 years ago

@alexcrichton I already wrote (helped by rustaceans!) an example of use of set_logger for the cookbook here: https://brson.github.io/rust-cookbook/logging.html#log-messages-with-a-custom-logger

Do you think we have to write a new different one? Or "copy/pasting" this one is OK? Maybe we should make a shorter example, but I don't know what to remove.

alexcrichton commented 7 years ago

@rap2hpoutre nah copy/pasting sounds great! No need to create more work when it's already done :)

rap2hpoutre commented 7 years ago

@alexcrichton Ok done for the example part! see: https://github.com/rust-lang-nursery/log/pull/186

alexcrichton commented 7 years ago

Awesome! In that case closing.

budziq commented 7 years ago

@alexcrichton hi I would reopen as set_logger doc still misses links and errors section