Closed KodrAus closed 3 years ago
Ok, I've released 0.4.13
as a patch against 0.4.11
(which was the current release on crates.io
) with just an additional kv_unstable_std
feature to minimize any disruption from upgrading libraries.
Just a small question as 0.4.12
has been yanked: will 0.4.14
be based on master and contain the toml changes that have cfg-if = "1.0"
or will it be based on 0.4.13
which has that reverted?
I'm currently blocked upgrading some of my project dependencies because cfg-if = "1.0"
can't be fulfilled, so I'm really looking forward for such a release. :cat:
@anthraxx what's blocking you? You should be able to use cfg-if = "0.1"
, even have both dependencies. (May be undesirable but AFAIK cfg-if
is just a macro, so shouldn't be a big deal.)
Ok, well, "soft blocking" my CI as clippy is not happy like a hippo :smirk_cat:
cargo clippy
Checking somerustproject v0.0.1 (somerustproject)
error: multiple versions for dependency `cfg-if`: 0.1.10, 1.0.0
|
note: the lint level is defined here
--> src/main.rs:1:26
|
1 | #![deny(clippy::nursery, clippy::cargo)]
@anthraxx It will be based on master
so will be everything we wish 0.4.12
was.
0.4.13
is a real stop-gap release so we can help some of the libraries in the OP get prepared for a change in unstable feature flags.
@anthraxx perhaps change that lint to warning? Seems overly-restrictive to me, especially in this case. Looks like clippy can't be configured more granularly here. I filed https://github.com/rust-lang/rust-clippy/issues/6596
It's been a little while so I'm going to work on getting this released today.
Ok, 0.4.14
is now published. There is some breakage in the unstable kv
API, so I'll keep this issue open for now. Rather than yanking the release this time I'll work on helping any crates that are broken to update.
I'm hoping that we'll only have one more possible release that might make breaking changes to kv
: the one that stabilizes it.
;? ' o m nl,l,l,l,l,l,l,l,l,l,l,l,l,l,l,l,uyuuuuuuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuyuuyguyyyyyyygnugyg,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,mmm
EDIT: Baby's first GitHub comment 😄
This has been out for about a little while now so I'll go ahead and close this one.
There was a change to the way the
kv_unstable
API works between0.4.11
and0.4.13
that requires users to add thekv_unstable_std
feature instead of juststd
.We do reserve the right to break this feature in patch bumps (otherwise we'd never be able to develop it), but don't want to drop broken code without supporting the people who've taken bets on it.
This issue will track coordinating that release.
Libraries to update
Direct dependencies on
log
withkv_unstable
:Direct dependencies with
kv_unstable
andstd
:Known to depend on
log
withkv_unstable
transitively withstd
implicitly: