Set all crates to 2021 edition

rust-lang / log

Logging implementation for Rust

https://docs.rs/log

Apache License 2.0

2.16k stars 250 forks source link

Set all crates to 2021 edition #580

Closed nyurik closed 1 year ago

nyurik commented 1 year ago

For some reason all crates still use 2015 edition. I think it is a good idea to specify edition explicitly, or at least document why it should be kept back (and still add it to the cargo.toml for documentation purposes)

Remove all extern crate
changed use self::sval::... to use sval::..., and the same for sval_ref
Simplified fn get<'v>(&'v self, key: Key) -> Option<Value<'v>> to fn get(&self, key: Key) -> Option<Value<'_>>
Simplified many unit tests with references

nyurik commented 1 year ago

It took a few tries, but I think I fixed all the outstanding issues with this one. As the result, 50 less lines of code, and a few extra CI checks.

KodrAus commented 1 year ago

Thanks for doing some much needed housekeeping @nyurik! It looks like we just have some conflicts to resolve now.

nyurik commented 1 year ago

thx @KodrAus, rebased & fixed

nyurik commented 1 year ago

@KodrAus hi, would you be the right person to review? I would like to make a few more improvements like use workspaces, but all other changes would be based on this one, so I don't want to make them until this is agreed on & merged. Thx!

KodrAus commented 1 year ago

Merged! Thanks again @nyurik