Closed nyurik closed 1 year ago
It took a few tries, but I think I fixed all the outstanding issues with this one. As the result, 50 less lines of code, and a few extra CI checks.
Thanks for doing some much needed housekeeping @nyurik! It looks like we just have some conflicts to resolve now.
thx @KodrAus, rebased & fixed
@KodrAus hi, would you be the right person to review? I would like to make a few more improvements like use workspaces, but all other changes would be based on this one, so I don't want to make them until this is agreed on & merged. Thx!
Merged! Thanks again @nyurik
For some reason all crates still use 2015 edition. I think it is a good idea to specify edition explicitly, or at least document why it should be kept back (and still add it to the cargo.toml for documentation purposes)
extern crate
use self::sval::...
touse sval::...
, and the same forsval_ref
fn get<'v>(&'v self, key: Key) -> Option<Value<'v>>
tofn get(&self, key: Key) -> Option<Value<'_>>