Closed Thomasdezeeuw closed 6 months ago
Thanks for all the time you've spent digging through this so far @Thomasdezeeuw! I think we're getting towards something that feels appropriate for the log
crate without losing capability.
Just checking back in on this, is the main blocker we've got deciding whether to default to capturing using ToValue
and supporting some tracing
-like syntax for changing it?
Just checking back in on this, is the main blocker we've got deciding whether to default to capturing using
ToValue
and supporting sometracing
-like syntax for changing it?
Yes, I think those are the two main things from this pr.
I'm doing some work on this now; removing the Value::capture_*
and downcasting methods, and improving the overall documentation for the kv
module.
It looks like we already default to using ToValue
for key-values, so nothing needs to change there. That just leaves some nicer macro support for tweaking how values are captured.
Are you happy with that plan @Thomasdezeeuw?
I've opened #613 for this. I'll cc there once it's ready for review, but wanted to point it out here too.
Are you happy with that plan @Thomasdezeeuw?
Yes, sounds good :+1:
Discussion for https://github.com/rust-lang/log/issues/328.