search

rust-lang / log

Logging implementation for Rust
https://docs.rs/log
Apache License 2.0
2.18k stars 252 forks source link

Prepare for 0.4.21 release #617

Closed KodrAus closed 7 months ago

KodrAus commented 7 months ago

cc @Thomasdezeeuw @JohnTitor This release stabilizes our structured logging API.

Closes #616

What's Changed

nyurik commented 7 months ago

Should this be a minor change? I think we need to add two lines to the CI workflow as described here:

- name: Check semver
  uses: obi1kenobi/cargo-semver-checks-action@v2
nyurik commented 7 months ago

I just added https://github.com/rust-lang/log/pull/618 - it might need to go in first to make sure we are not accidentally breaking semver contract

nyurik commented 7 months ago

P.S. yes, it is clearly failing, possibly due to the current Cargo.toml having the same version as the published one. It seems patch version bump is not enough though.

My practice with that checker is that the version in the github main branch should be changed as soon as the breaking change is introduced. So either keep it as 0.5.0-pre.1 or as 0.5.0, but in either case it must not be 0.4.20 after the release and after the breaking changes are merged.

Thomasdezeeuw commented 7 months ago

Should this be a minor change?

What breaking changes do we have?

I think we need to add two lines to the CI workflow as described here:

Let's discuss this in the other pr.

nyurik commented 7 months ago

@Thomasdezeeuw I see a bunch of the breaking changes in https://github.com/rust-lang/log/actions/runs/8072374937/job/22053982534?pr=618 -- do you think they are not correct?

Thomasdezeeuw commented 7 months ago

@Thomasdezeeuw I see a bunch of the breaking changes in https://github.com/rust-lang/log/actions/runs/8072374937/job/22053982534?pr=618 -- do you think they are not correct?

Looking at that output. The as_map and as_list related stuff was removed on purpose. Two things renamed: Key::to_borrowed_str -> Key::as_str and Value::to_str -> Value::to_cow_str.

So it LGTM, all the changes were part of the unstable API.

KodrAus commented 7 months ago

Shipping this now :+1: I'll keep an eye on it over the next little while because releases with macro changes always come with risk.

KodrAus commented 7 months ago

@Thomasdezeeuw I've invited you to the organization I created where value-bag lives and will add you to the crate publishers too. Don't feel compelled to do anything if you're not interested (although you're very welcome to if you'd like!), but having permission to get builds and patches through there could be really useful someday.