refactor: Use axum for "mdbook serve"

rust-lang / mdBook

Create book from markdown files. Like Gitbook but implemented in Rust

https://rust-lang.github.io/mdBook/

Mozilla Public License 2.0

18.37k stars 1.65k forks source link

refactor: Use axum for "mdbook serve" #2359

Open audunhalland opened 7 months ago

audunhalland commented 7 months ago

This in my opinion brings mdbook's dependencies more in line with "the state of the art" of the Rust HTTP ecosystem. It pulls in hyper v1 and uses tower-http for filesystem serving functions.

I've manually tested serve with the test_book:

serving pages from the book works
websocket-based auto-reload works
404 page works

I can't guarantee though that there are no regressions. I did not find integrations tests for the serve command.

paolobarbolini commented 2 months ago

FWIW this seems the right call, as warp is still on hyper v0.14 and looking at their repository it gets almost no maintenance.