search

rust-lang / mdBook

Create book from markdown files. Like Gitbook but implemented in Rust
https://rust-lang.github.io/mdBook/
Mozilla Public License 2.0
18.37k stars 1.65k forks source link

Update pulldown-cmark to 0.11 #2381

Closed ehuss closed 6 months ago

ehuss commented 6 months ago

Changelog: https://github.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.11.0

Note that math is not yet supported. However, due to the new Event variant, I decided to include math script in the search index. I don't know if that is the right thing to do, but seems like something we can figure out later if we start using the math feature.

dylanowen commented 6 months ago

From the view of a preprocessor this isn't a SemVer compatible change and probably needs a minor version bump:

https://github.com/dylanowen/mdbook-graphviz/actions/runs/9120113600/job/25076838288?pr=132

expected `pulldown_cmark::Event<'_>`, found `Event<'_>`

Also pulldown-cmark-to-cmark doesn't seem to support 0.11 yet

ehuss commented 6 months ago

😦 Indeed. Thanks for letting me know. I did not realize the pulldown_cmark types were exposed, and we updated in 0.4.37 to 0.10 and nobody mentioned anything at the time.

I'll revert it for now. We'll probably need to do some kind of public re-export.

dylanowen commented 6 months ago

Thanks for the quick fix! I think we ran into issues with 0.4.37 as well but I neglected to warn anyone here 😬:

https://github.com/dylanowen/mdbook-graphviz/issues/107#issuecomment-1939140745