search

rust-lang / mdBook

Create book from markdown files. Like Gitbook but implemented in Rust
https://rust-lang.github.io/mdBook/
Mozilla Public License 2.0
17.84k stars 1.62k forks source link

Upgrade pulldown cmark #2401

Open Roms1383 opened 3 months ago

Roms1383 commented 3 months ago

Hi and thanks for this beautiful piece of tooling, I simply love it since the first time I discovered it!

I updated pulldown-cmark but noticed the comment saying not to in Cargo.toml, so feel free to dismiss this PR if this is not supposed to happen from an external contribution.

If however you do accept this PR, I'd like to add a mathematical expression to the tests for the sake of completeness but I'd appreciate that you point me which markdown is the most appropriate, so putting this under draft for now.

Thanks!

Roms1383 commented 1 month ago

Sorry for the ping @ehuss, but from a glance at latest commits it seem you're in charge of PRs. Any update on this ? pulldown-cmark has released a new version 0.12.0 in the meantime.

Also, saw mention in the guide of bumping version, am I allowed to do so ? Semver check recommends 0.5.0, but I imagine you would gather the changes of many a contributor first ?

ehuss commented 1 month ago

As the comment says, we can't update it at this time. See #2387. We will likely update this when we do a 0.5 release.