search

rust-lang / mdBook

Create book from markdown files. Like Gitbook but implemented in Rust
https://rust-lang.github.io/mdBook/
Mozilla Public License 2.0
18.42k stars 1.65k forks source link

gate few deps only used in bin by cli feature #2410

Open klensy opened 4 months ago

klensy commented 4 months ago

This adds cli feature (added to default list to prevent possible break) which gates deps used only by mdbook bin. This technically breaks users of bin with default-features = false, are they exist?

ehuss commented 4 months ago

Unfortunately we won't be able to make a change like this because it would break cargo install --no-default-features.

The main change in the 0.5 release is intended to fix this. I really want to get that rolling soon, it's just been hard to make time.

klensy commented 4 months ago

Looking at 0.5 milestone (https://github.com/rust-lang/mdBook/milestone/11) and don't see similar change, is there list with planned breaking changes somewhere else?

klensy commented 4 months ago

Something like #1937, which is not labeled :-(

ehuss commented 4 months ago

I don't think there is a list besides the milestone. The primary thing is to split it into multiple packages, and do some API cleanup to fix backwards-compatibility issues to make it easier to update things.