search

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation
Apache License 2.0
4.31k stars 327 forks source link

many-seeds: propagate failure properly #3406

Closed RalfJung closed 5 months ago

RalfJung commented 5 months ago

Fixes https://github.com/rust-lang/miri/issues/3405.

RalfJung commented 5 months ago

Okay so now it indeed does fail on Windows. But in a strange way:

 Error: io error when running command `./miri run tests/many-seeds/scoped-thread-leak.rs`: %1 is not a valid Win32 application. (os error 193)

@ChrisDenton can Command not spawn scripts on Windows? Would it work to run the batch script instead of the bash script?

ChrisDenton commented 5 months ago

On Windows you can only reliably run exe files.

https://github.com/rust-lang/rust/issues/94743 has some more details (though ultimately adding support for scripts was not popular)

RalfJung commented 5 months ago

Then either we can get bash to launch the script for us or we'll have to disable the test on Windows. I don't want to duplicate the logic from './miri' that computes where the binary is.

RalfJung commented 5 months ago

This might work... @bors r+

bors commented 5 months ago

:pushpin: Commit 5759160a4941ced1770d3b614a5e1d5f1e709988 has been approved by RalfJung

It is now in the queue for this repository.

bors commented 5 months ago

:hourglass: Testing commit 5759160a4941ced1770d3b614a5e1d5f1e709988 with merge 344ea00936b879460f06156fdf88301159a7ac55...

bors commented 5 months ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing 344ea00936b879460f06156fdf88301159a7ac55 to master...