search

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation
Apache License 2.0
4.31k stars 327 forks source link

run GC stress test only for host tests #3432

Closed RalfJung closed 5 months ago

RalfJung commented 5 months ago

I suspect these are a significant contributor to our Linux CI job being by far the slowest currently. Let's see.

We have Linux, Windows, and macOS hosts so all major OSes are still covered.

RalfJung commented 5 months ago

Oh wow yes, this cuts Linux CI time from ~53 to 23 minutes, so what was previously the slowest builder is now the fastest.^^

RalfJung commented 5 months ago

@rust-lang/miri any objections to this? The macOS run was unusually slow in this PR, usually it's below 30m.

The Windows run is often close to 50min, that is the bottleneck. We currently test 3 foreign targets on Windows, it probably makes sense to move 2 of them to the Linux runner. (I'd like to have one 64bit Unix target still there to test "64bit target on 32bit host" and "Unix target on Windows host".)

saethlin commented 5 months ago

This change seems quite reasonable to me.

RalfJung commented 5 months ago

Windows still took 42 minutes... if it remains the bottleneck I'm considering just not doing the many-seeds and mir-opt-level=4 tests on Windows; doing those on macOS and Linux should suffice.

But for now let's land this. @bors r+

bors commented 5 months ago

:pushpin: Commit f715007da1498a419180b2e77356dc3ad342e6bd has been approved by RalfJung

It is now in the queue for this repository.

bors commented 5 months ago

:hourglass: Testing commit f715007da1498a419180b2e77356dc3ad342e6bd with merge e3dd7e0ae3b76160c9051eecd3d13ff5fe29365b...

bors commented 5 months ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing e3dd7e0ae3b76160c9051eecd3d13ff5fe29365b to master...