Make `split_simd_to_128bit_chunks` take only one operand

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation

Apache License 2.0

4.18k stars 323 forks source link

Closed eduardosm closed 3 months ago

eduardosm commented 3 months ago

It will allow more flexible uses in the future. This makes split_simd_to_128bit_chunks simpler, moving some of the complexity to its callers.

RalfJung commented 3 months ago

r=me with the comment improved.

@bors delegate+

bors commented 3 months ago

:v: @eduardosm, you can now approve this pull request!

If @RalfJung told you to "r=me" after making some further change, please make that change, then do @bors r=@RalfJung

eduardosm commented 3 months ago

@bors r=@RalfJung

bors commented 3 months ago

:pushpin: Commit 2d90a21dbf4b4ab69110d7f9ae4a8b8eb6d9648e has been approved by RalfJung

It is now in the queue for this repository.

bors commented 3 months ago

:hourglass: Testing commit 2d90a21dbf4b4ab69110d7f9ae4a8b8eb6d9648e with merge f323c58f4f6ac5078c3f284c2d2d2ea2473c7845...

eduardosm commented 3 months ago

CI passed but didn't get merged?

RalfJung commented 3 months ago

Yeah bors is on strike... Again. We can just hope it sorts itself out...

RalfJung commented 3 months ago

@bors retry

bors commented 3 months ago

:hourglass: Testing commit 2d90a21dbf4b4ab69110d7f9ae4a8b8eb6d9648e with merge c4b4c2813404adb786dd3a957e6b1562bc2113cb...

bors commented 3 months ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing c4b4c2813404adb786dd3a957e6b1562bc2113cb to master...

bors commented 3 months ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing c4b4c2813404adb786dd3a957e6b1562bc2113cb to master...