directly call handle_alloc_error

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation

Apache License 2.0

4.18k stars 323 forks source link

directly call handle_alloc_error #3480

Closed RalfJung closed 3 months ago

RalfJung commented 3 months ago

Also test more codepaths. There's like 5 different things that can happen on allocation failure! Between -Zoom, #[alloc_error_handler], and set_alloc_error_hook, we have 3 layers of behavior overrides. It's all a bit messy.

https://github.com/rust-lang/rust/pull/112331 seems intended to clean this up, but has not yet reached consensus.

RalfJung commented 3 months ago

@bors r+

bors commented 3 months ago

:pushpin: Commit 1f1f613ba49a6ed8b69d222db4270358080b2fc1 has been approved by RalfJung

It is now in the queue for this repository.

bors commented 3 months ago

:hourglass: Testing commit 1f1f613ba49a6ed8b69d222db4270358080b2fc1 with merge dcd17c96be95e20becbac0f09803d2e28f117087...

bors commented 3 months ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing dcd17c96be95e20becbac0f09803d2e28f117087 to master...