search

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation
Apache License 2.0
4.17k stars 320 forks source link

Upgrade to `actions/checkout@v4` in `ci.yml`. #3511

Closed obi1kenobi closed 2 months ago

obi1kenobi commented 2 months ago

This is a newer version of the same action. None of the uses here were particularly special (no complex features of v3 were used) so this is a straightforward as-is upgrade.

RalfJung commented 2 months ago

Thanks! I don't understand why github makes everyone do this every other year or so... oh well.

@bors r+

bors commented 2 months ago

:pushpin: Commit 743ab271d7e659ce6b176a1087d8e4849c412460 has been approved by RalfJung

It is now in the queue for this repository.

bors commented 2 months ago

:hourglass: Testing commit 743ab271d7e659ce6b176a1087d8e4849c412460 with merge e6914bb13a6dc50af34934b7f481e32ef2deb3a6...

obi1kenobi commented 2 months ago

There's technically a breaking change between v3 and v4, just one that affects very few use cases in practice. So I think they did the right thing, even though it's a bit annoying that almost everyone has to actively upgrade even though they aren't affected.

Btw, GitHub's Dependabot can keep actions updated to the latest versions -- I have that configured in cargo-semver-checks and it's worked well so far. If you'd like, I'd be happy to add a similar config here: once a week, it will open PRs with any upgraded actions versions that are available.

RalfJung commented 2 months ago

Thanks! I think we'll wait for other rust-lang projects to do something like that before considering it.

obi1kenobi commented 2 months ago

Makes sense. Open offer, ping me anytime if you or someone in another rust-lang project wants to try it. Happy to help.

bors commented 2 months ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing e6914bb13a6dc50af34934b7f481e32ef2deb3a6 to master...