rust-lang / miri

An interpreter for Rust's mid-level intermediate representation
Apache License 2.0
4.39k stars 340 forks source link

env: split up Windows and Unix environment variable handling #3517

Closed RalfJung closed 5 months ago

RalfJung commented 5 months ago

On Windows, manage them entirely outside the AM state; this also means we no longer report any data races for environment variable memory.

Fixes https://github.com/rust-lang/rust/issues/124411

RalfJung commented 5 months ago

@bors r+

bors commented 5 months ago

:pushpin: Commit 96fcee18e870005b98605d1e63b0cfb3cc345323 has been approved by RalfJung

It is now in the queue for this repository.

bors commented 5 months ago

:hourglass: Testing commit 96fcee18e870005b98605d1e63b0cfb3cc345323 with merge acf44cbbcae671d0b82691bd0e7b52391d6e404c...

bors commented 5 months ago

:broken_heart: Test failed - checks-actions

RalfJung commented 5 months ago

@bors r+

bors commented 5 months ago

:pushpin: Commit c53d44b9b2a96ac9bd656ab5ca3e66721f97f713 has been approved by RalfJung

It is now in the queue for this repository.

bors commented 5 months ago

:hourglass: Testing commit c53d44b9b2a96ac9bd656ab5ca3e66721f97f713 with merge 6b787f93099c64571d26ad3150afeac1c91c8332...

bors commented 5 months ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing 6b787f93099c64571d26ad3150afeac1c91c8332 to master...