search

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation
Apache License 2.0
4.17k stars 320 forks source link

bump actions/cache to v4 #3519

Closed hamirmahal closed 2 months ago

hamirmahal commented 2 months ago

fixes #3518.

saethlin commented 2 months ago

I'm happy to take the second commit, but not the formatting changes. For example, consider some other drive-by contributor who has their YAML config set up for 2-space indentations. They'd submit essentially the opposite change as you have with the same justification.

Drop the first commit and I'll approve the version bump of the checkout action. If use a YAML formatter, I at least want to pin its settings and discuss that separately. Pinning the formatter settings would make either one of you or the imaginary two-space contributor correct, as opposed to both prescribing a huge diff with no clear value.

RalfJung commented 2 months ago

Thanks! Github really likes people doing manual version bumps all the time...

@bors r+

bors commented 2 months ago

:pushpin: Commit 565f9a92114d431774c48bd2476c52c4ed722f9a has been approved by RalfJung

It is now in the queue for this repository.

bors commented 2 months ago

:hourglass: Testing commit 565f9a92114d431774c48bd2476c52c4ed722f9a with merge 6e4283075c8d746ce991b142265dd884c612b45b...

hamirmahal commented 2 months ago

You're welcome!

bors commented 2 months ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing 6e4283075c8d746ce991b142265dd884c612b45b to master...