search

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation
Apache License 2.0
4.16k stars 318 forks source link

update host-float comments #3535

Closed RalfJung closed 2 months ago

RalfJung commented 2 months ago

Turns out most of these do not have guaranteed precision anyway so it's fine to use host floats (see https://github.com/rust-lang/rust/pull/121793 and https://github.com/rust-lang/rust/pull/118217). The exception are sqrt and mul_add, tracked at https://github.com/rust-lang/miri/issues/3534 and https://github.com/rust-lang/miri/issues/2995.

RalfJung commented 2 months ago

@bors r+

bors commented 2 months ago

:pushpin: Commit 79a157a85a94d0526817bd7e41d3bec3f023334e has been approved by RalfJung

It is now in the queue for this repository.

bors commented 2 months ago

:hourglass: Testing commit 79a157a85a94d0526817bd7e41d3bec3f023334e with merge fe1424acc4bcc4dd7367cbcd850f50b2b8227867...

bors commented 2 months ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing fe1424acc4bcc4dd7367cbcd850f50b2b8227867 to master...