search

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation
Apache License 2.0
4.38k stars 339 forks source link

Solaris: make pre-main code work #3570

Closed devnexen closed 5 months ago

devnexen commented 5 months ago

Fixes https://github.com/rust-lang/miri/issues/3566

RalfJung commented 5 months ago

You lost the changes in ci.sh so currently this won't be tested.

RalfJung commented 5 months ago

Also your commits are still coming from the future. ;)

image

This seems to confuse github as well (when I post a comment, often it doesn't appear until I reload the page), so it would be good if you could fix your system clock.

RalfJung commented 5 months ago

Okay looks like just leaving it at 0 doesn't work.^^ It triggers an underflow here. Most tests work though, only spawning new threads fails -- nice!

So stack_getbounds will have to actually store the stack address and size in the appropriate fields of the struct. You can use this shim as a template. This is the struct that the pointer should point to.

RalfJung commented 5 months ago

Looks good, thanks!

Please squash the commits.

RalfJung commented 5 months ago

Awesome. :) @bors r+

bors commented 5 months ago

:pushpin: Commit f47926c6f652dabfa1581ed23177375f42a50c82 has been approved by RalfJung

It is now in the queue for this repository.

bors commented 5 months ago

:hourglass: Testing commit f47926c6f652dabfa1581ed23177375f42a50c82 with merge 193aafeabcd7ca48135a16639562cfe9c7883bd2...

bors commented 5 months ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing 193aafeabcd7ca48135a16639562cfe9c7883bd2 to master...