rust-lang / miri

An interpreter for Rust's mid-level intermediate representation
Apache License 2.0
4.16k stars 318 forks source link

Revamp "./miri test": parse --target ourselves, pass the rest to the test harness #3586

Closed RalfJung closed 1 month ago

RalfJung commented 1 month ago

./miri test <flags> just sends all the flags to cargo as-is. That's suboptimal for (at least) two reasons:

So I think we should make this command be ./miri test [--target target] <flags>, where target does the same thing as MIRI_TEST_TARGET, and <flags> are passed to the test harness -- i.e., the invocation will be cargo test -- <flags> (note the extra --).

RalfJung commented 1 month ago

@RossSmyth would you like to give this a try? :)

RossSmyth commented 1 month ago

3588

Don't worry, I planned on working on it :)

RalfJung commented 1 month ago

Fixes by https://github.com/rust-lang/miri/pull/3588