search

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation
Apache License 2.0
4.16k stars 318 forks source link

Don't print unnecessary sysroot messages #3599

Closed saethlin closed 1 month ago

saethlin commented 1 month ago

Currently, when running cargo miri setup, we always print that a sysroot is being prepared, even if we just bail out of building after checking the hash. So that message is wrong; we didn't actually prepare a sysroot.

We also always print the preparing message for cargo miri run, even if no sysroot is prepared.

With this PR, cargo miri run prints no sysroot messages when an existing one is reused, and when a redundant cargo miri setup is requested, we print:

A sysroot for Miri is already available in `/home/ben/.cache/miri`.
saethlin commented 1 month ago

Ah, fmt.

RalfJung commented 1 month ago

I published a new rustc-build-sysroot, can you update the PR?

RalfJung commented 1 month ago

LGTM, thanks! @bors r+

bors commented 1 month ago

:pushpin: Commit a18a0f86c458ad93b3616e3e499fc60a4f190ce8 has been approved by RalfJung

It is now in the queue for this repository.

bors commented 1 month ago

:hourglass: Testing commit a18a0f86c458ad93b3616e3e499fc60a4f190ce8 with merge 8617fc4f435aeb1f4766a3e70eb85cf439bf5484...

bors commented 1 month ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing 8617fc4f435aeb1f4766a3e70eb85cf439bf5484 to master...

bors commented 1 month ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing 8617fc4f435aeb1f4766a3e70eb85cf439bf5484 to master...