add support for `pclmulqdq` intrinsic

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation

Apache License 2.0

4.14k stars 318 forks source link

add support for `pclmulqdq` intrinsic #3640

Closed folkertdev closed 3 weeks ago

folkertdev commented 1 month ago

This instruction is required in fast implementations of the crc32 checksum algorithm, and used in the https://crates.io/crates/crc32fast and https://crates.io/crates/zlib-rs crates.

Some questions from my side

is my method for decomposing a __m128i into two separate i64 values allright?

folkertdev commented 1 month ago

@rustbot ready

RalfJung commented 3 weeks ago

@rustbot author

folkertdev commented 3 weeks ago

@rustbot ready

RalfJung commented 3 weeks ago

In future please avoid force-pushing (except when there are conflicts that need resolving) until the PR is done. Github is pretty bad at keeping track of force-pushes, making it basically impossible to tell what changed since my last review.

RalfJung commented 3 weeks ago

Thanks. :-)

@bors r+

bors commented 3 weeks ago

:pushpin: Commit 6a866881fdc75a2edbc741cbe58a0638cb093c68 has been approved by RalfJung

It is now in the queue for this repository.

bors commented 3 weeks ago

:hourglass: Testing commit 6a866881fdc75a2edbc741cbe58a0638cb093c68 with merge e191feec3d7375d6a190b730dbb55cb3c4d15b62...

bors commented 3 weeks ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing e191feec3d7375d6a190b730dbb55cb3c4d15b62 to master...