search

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation
Apache License 2.0
4.14k stars 318 forks source link

Draft: Create _umtx_op shim for FreeBSD #3649

Open b-ncMN opened 3 weeks ago

b-ncMN commented 3 weeks ago

This PR lays the basic works for the _umtx_op shim for freebsd

I have implemented this by taking inspiration from the linux futex shim, so it may not be perfect and I am looking forward to criticism.

I will continue that on later commits because the tests do not currently pass

RalfJung commented 3 weeks ago

Just one quick nit because I saw the notification, the PR description and commit message could be a bit more descriptive. :) They should mention _umtx_op, and probably FreeBSD.

b-ncMN commented 3 weeks ago

I think all of these commits will be merged into one before pulling this in main. I tried to keep every commits as clean as possible. But it seems I am stuck on a clippy warning on HEAD, is it worth for me to fix it in order to keep the tree clean or is that not really a problem? Because further commit will override that faulty code and it will be all in one commit after.

RalfJung commented 3 weeks ago

When you mark this as ready for review, CI must be green. We won't land code that has clippy warnings.

For intermediate commits it doesn't matter.