search

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation
Apache License 2.0
4.13k stars 318 forks source link

Minor fix: Change wording of epoll_create1 and socketpair's throw_unsup_format #3671

Closed tiif closed 2 weeks ago

tiif commented 2 weeks ago

This PR slightly changes the wording and format of epoll_create1's throw_unsup_format to match other shims. It is just a minor detail that I couldn't help but want to change while reading it. Sorry if it is not appropriate to open a PR for such minor detail.

RalfJung commented 2 weeks ago

This PR slightly changes the wording and format of epoll_create1's throw_unsup_format to match other shims.

Which other shims? Given that I suggested you change the wording, are there other shims that should also be changed?

tiif commented 2 weeks ago

socketpair used similar wording. I can change them together here.

RalfJung commented 2 weeks ago

Please do. :)

RalfJung commented 2 weeks ago

Thanks! @bors r+

bors commented 2 weeks ago

:pushpin: Commit 4f489a9b0109464a42076d0fd18adae7a63c3e21 has been approved by RalfJung

It is now in the queue for this repository.

bors commented 2 weeks ago

:hourglass: Testing commit 4f489a9b0109464a42076d0fd18adae7a63c3e21 with merge d3aa763a0fd76a873d8eb3a167ea4ff8804d1e30...

bors commented 2 weeks ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing d3aa763a0fd76a873d8eb3a167ea4ff8804d1e30 to master...