cargo miri: add support for '--many-seeds'

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation

Apache License 2.0

4.37k stars 337 forks source link

cargo miri: add support for '--many-seeds' #3672

Closed RalfJung closed 3 months ago

RalfJung commented 3 months ago

to run the program / tests many times with different seeds: cargo miri run --many-seeds / cargo miri test --many-seeds.

@rust-lang/miri any opinion on the flag name here? Should it be -Zmiri-many-seeds or is --many-seeds fine?

Fixes https://github.com/rust-lang/miri/issues/3546

saethlin commented 3 months ago

I think --many-seeds is better. I don't see any reason to claim this is unstable/experimental by making it a -Z flag, we've been doing this many seeds thing for years and I think it has proven its value.

RalfJung commented 3 months ago

All right, let's land this then. We can always adjust this later.

@bors r+

bors commented 3 months ago

:pushpin: Commit e81fa00d00a6dfca9ed2d2092809ad0cd3bc243c has been approved by RalfJung

It is now in the queue for this repository.

bors commented 3 months ago

:hourglass: Testing commit e81fa00d00a6dfca9ed2d2092809ad0cd3bc243c with merge 60a720040d6c60656ab9cac0980e587d19d9c07a...

bors commented 3 months ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing 60a720040d6c60656ab9cac0980e587d19d9c07a to master...

ibraheemdev commented 2 months ago

--many-seeds doesn't seem to run integration tests, was this intentional?

RalfJung commented 2 months ago

I am not sure what you mean. Test selection is independent of this flag.

Please file an issue with reproducible instructions.