search

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation
Apache License 2.0
4.13k stars 318 forks source link

Implement LLVM x86 bmi intrinsics #3674

Closed TDecking closed 1 week ago

TDecking commented 1 week ago

This implements the intrinsics for both the bmi1 and bmi2 ISA extensions. All of these intrinsics live inside the same namespace as far as LLVM is concerned, which is why it is arguably better to bundle the implementations of these two extensions.

TDecking commented 1 week ago

@rustbot ready

rustbot commented 1 week ago

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/miri.git master
$ git push --force-with-lease

The following commits are merge commits:

TDecking commented 1 week ago

@RalfJung All the comments are added.

RalfJung commented 1 week ago

Thanks, looks good! Please squash the commits.

TDecking commented 1 week ago

Everything is ready.

TDecking commented 1 week ago

@rustbot ready

RalfJung commented 1 week ago

Awesome, thanks for the PR and the adjustments during review. :)

@bors r+

bors commented 1 week ago

:pushpin: Commit 459eadaf8a1fdb40603410f4935fd0f3e27b7404 has been approved by RalfJung

It is now in the queue for this repository.

bors commented 1 week ago

:hourglass: Testing commit 459eadaf8a1fdb40603410f4935fd0f3e27b7404 with merge cc9699dc545e046e8fde9a2da315787ce07c7cb1...

bors commented 1 week ago

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing cc9699dc545e046e8fde9a2da315787ce07c7cb1 to master...