search

rust-lang / miri

An interpreter for Rust's mid-level intermediate representation
Apache License 2.0
4.37k stars 337 forks source link

clarify the warning shown when optimizations are enabled, and the status of Tree Borrows #3709

Closed RalfJung closed 3 months ago

RalfJung commented 3 months ago

We can use some other term, but something is ignored and I think we should say that. I think cargo calls this "opt-level"?

saethlin commented 3 months ago

Yeah, Cargo and rustc both call it opt-level. Rusty's -O is opt-level=2, but in GCC and clang it's equivalent to -O1 and I strongly suspect that the most used nonzero opt level in Rust is 3 because that's the default for Cargo's --release.

I remain surprised that this chaos hasn't caused issues for the compiler's codegen tests.

RalfJung commented 3 months ago

@bors r=saethlin

bors commented 3 months ago

:pushpin: Commit 4f7bc6ad8698d581a4ec25c44a06586feacd0964 has been approved by saethlin

It is now in the queue for this repository.

bors commented 3 months ago

:hourglass: Testing commit 4f7bc6ad8698d581a4ec25c44a06586feacd0964 with merge b8dffc5ae01be8cde6dbd07488ee015c479b68fb...

bors commented 3 months ago

:sunny: Test successful - checks-actions Approved by: saethlin Pushing b8dffc5ae01be8cde6dbd07488ee015c479b68fb to master...