Rewrite the chapter on subtyping and variance

rust-lang / nomicon

The Dark Arts of Advanced and Unsafe Rust Programming

https://doc.rust-lang.org/nomicon/

Apache License 2.0

1.82k stars 263 forks source link

Rewrite the chapter on subtyping and variance #340

Closed conradludgate closed 1 year ago

conradludgate commented 2 years ago

This is to address the issues raised in #339

conradludgate commented 2 years ago

Thanks everyone for the reviews. It seems overall people are in favour of this general form but there's a bit of bike shedding over syntax.

I'll make all the grammatical and language changes suggested

jackh726 commented 2 years ago

@conradludgate the types team (wg-traits on zulip) is planning to go over this PR next Friday at 9 am Eastern Time. You're welcome to join if you'd like!

jyn514 commented 1 year ago

oof, it's been a while ... what's the current state of this PR?

I would prefer to merge this even if it's not 100% complete rather than have it hang in limbo; we can always improve it in follow-ups and my understand is it's already more accurate than the existing docs.