search

rust-lang / nomicon

The Dark Arts of Advanced and Unsafe Rust Programming
https://doc.rust-lang.org/nomicon/
Apache License 2.0
1.74k stars 256 forks source link

Ignore a doctest that will be broken by a stabilization #444

Closed Nadrieril closed 3 months ago

Nadrieril commented 3 months ago

Over at https://github.com/rust-lang/rust/pull/122792, I'm proposing to stabilize a feature that will allow let Ok(x) = result; to compile for result: Result<T, Void>. Problem is, the nomicon contains a doctest that asserts that this doesn't compile. Which breaks CI on my stabilization PR :grin:.

I don't know if there's a standard procedure for this, so I thought I'd ignore the test here first, wait for submodule update on the rustc side, which will allow my PR to pass CI. If it gets merged we can re-enable the doctest and update it. If the stabilization doesn't go through we can just revert this. Is that sensible?

Nadrieril commented 3 months ago

Oh, it seems nomicon doctests are run in CI but aren't blocking