search

rust-lang / packed_simd

Portable Packed SIMD Vectors for Rust standard library
https://rust-lang.github.io/packed_simd/packed_simd_2/
Apache License 2.0
590 stars 74 forks source link

unnecessary `unsafe` block error with rustc 1.39.0-nightly #265

Closed 3for closed 3 years ago

3for commented 5 years ago

git clone the source code, and run cargo build， an "unnecessary unsafe block" error occurred. My rust version is rustc 1.39.0-nightly (9b91b9c10 2019-08-26). image

It will be solved by remove the unsafe block. image

gnzlbg commented 5 years ago

The better fix here is to remove the #[deny(warnings)] from the lib.rs and instead pass it to cargo in CI via RUSTFLAGS.

3for commented 5 years ago

Good idea. I've open the warnings instead of remove unsafe block.

Lokathor commented 3 years ago

@3for if i understand correctly, by changing the warning level you've resolved this particular problem? Should we close the issue?

3for commented 3 years ago

@Lokathor Yes, we can close this issue.