rust-lang / packed_simd

Portable Packed SIMD Vectors for Rust standard library
https://rust-lang.github.io/packed_simd/packed_simd_2/
Apache License 2.0
589 stars 74 forks source link

Update features.md to reflect minimum SIMD requirements #362

Closed CKingX closed 4 months ago

CKingX commented 4 months ago
CKingX commented 4 months ago

I don't think the tests are failing due to the change as I only updated the features page of the performance guide.

workingjubilee commented 4 months ago

Oh yes, several fundamental ideas that this crate hinges on got rewritten.

workingjubilee commented 4 months ago

@CKingX I have no intention of merging your change, sorry! This documentation should go to the rust-lang/rust repository, for the platform support pages hereish: https://github.com/rust-lang/rust/tree/master/src/doc/rustc/src

CKingX commented 4 months ago

So I looked into the platform support and it doesn't make sense to put it in there. I also don't think constantly updating features.md whenever a target changes makes sense. Would it make sense to create a new PR explaining that you can look up the default target features with rustc --print cfg or for other targets, rustc --print cfg --target={target}?

workingjubilee commented 4 months ago

Not even in the docs for the targets? https://github.com/rust-lang/rust/tree/master/src/doc/rustc/src/platform-support

And sure...?

CKingX commented 4 months ago

Thanks! I will look into updating those docs.

CKingX commented 4 months ago

It seems a lot of the docs on the targets list if things like SSE are disabled. Would it make sense updating the Windows 7 target arch to list it only supports SSE2 by default unlike the regular targets?

Also thank you for your help!