search

rust-lang / polonius

Defines the Rust borrow checker.
Apache License 2.0
1.35k stars 73 forks source link

Dump path_maybe_uninitialized_on_exit after compute_move_errors #150

Closed utaal closed 4 years ago

utaal commented 4 years ago

When called with --show-tuples and -v.

This may be useful to debug move_errors. If I missed the reason why this shouldn't be dumped, let me know!

amandasystems commented 4 years ago

Thanks! Pretty sure it was a mistake on my part leaving it out, but I’ll let the others chime in as well :)

lqd commented 4 years ago

We probably haven't needed it just yet yeah :)

The verbose debug output can easily become overwhelming and hide the information you're looking for on the bigger datasets.

Thanks @utaal

utaal commented 4 years ago

Makes sense. Thanks!

The verbose debug output can easily become overwhelming and hide the information you're looking for on the bigger datasets.

What do you folks think of pre-pending the relation name to each fact on the debug output? This way when searching/grep-ing for an atom you can easily see all the facts (and relations) it appears in.

Something like this: https://gist.github.com/utaal/a88be7de8cbdd1e36c8a0a177489bdcf A possible PR for this: https://github.com/rust-lang/polonius/compare/master...utaal:print-relation