search

rust-lang / polonius

Defines the Rust borrow checker.
Apache License 2.0
1.35k stars 73 forks source link

Switch from Travis to Github Actions #164

Closed lqd closed 3 years ago

lqd commented 3 years ago

Our CI has 👻-ed us, so let's try switching to GHA.

@Mark-Simulacrum does that look good to you ?

I've tested this a bit on my fork, and it seemed to work.

I'm a bit unsure about the book job: I don't have the admin rights to check if the actual tokens set up on this repo would keep working with the new simpleinfra job, or if new tokens or deploy keys would be needed.

Mark-Simulacrum commented 3 years ago

Not sure if GH CI isn't running on this PR for a particular reason or what's up with that - would probably be good to figure that out. Otherwise modulo one nit I left seems good to me, I would expect best way to test is to merge...

lqd commented 3 years ago

Maybe for the first GHA workflow has to be enabled via the UI... It's running now, so I'll be able to test the book parts.

lqd commented 3 years ago

Seems ok up to actually deploying the book, using the tokens. So let's merge and test that. The currently deployed book is out of date anyways.

lqd commented 3 years ago

Looking good

bjorn3 commented 3 years ago

Github actions is only activated for PRs once a workflow gets merged into the default branch.