search

rust-lang / prev.rust-lang.org

The previous Rust website. The current website's code is at https://github.com/rust-lang/www.rust-lang.org.
https://prev.rust-lang.org
Apache License 2.0
151 stars 340 forks source link

Replaced the broken link to libs.rs with... #1051

Closed mark-summerfield closed 6 years ago

mark-summerfield commented 6 years ago

one to crates.io (but it doesn't seem to work as a link, but at least it is the right thing to say).

rust-highfive commented 6 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

ashleygwilliams commented 6 years ago

hi @mark-summerfield ! in order to get the link to work as you have written it you'll need to add a link at the bottom of the page, something like [crates.io]: https://crates.io/. you'll probably also want to remove the link you are removing! lemme know if you need anything further help!

great find on the broken link btw! really appreciate this PR :D

mark-summerfield commented 6 years ago

I've added the change you suggested but don't know what I'm supposed to do next.

ashleygwilliams commented 6 years ago

great- this looks perfect except now we just need to remove the [libs.rs] link down on the bottom. once that is done i can merge this and it will be shipped! thanks again :D