search

rust-lang / prev.rust-lang.org

The previous Rust website. The current website's code is at https://github.com/rust-lang/www.rust-lang.org.
https://prev.rust-lang.org
Apache License 2.0
153 stars 340 forks source link

Remove "click here" from flash banner and increase clickable area #1245

Closed wikku closed 5 years ago

rust-highfive commented 5 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ashleygwilliams (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

ashleygwilliams commented 5 years ago

thanks for this @wiktorkuchta ! could you include a screenshot? if everything looks good i'm happy to merge :D

wikku commented 5 years ago

image

The layout doesn't change on any screen size, only the text and clickable area. It's easy to preview the changes by using browser Dev Tools