search

rust-lang / reference

The Rust Reference
https://doc.rust-lang.org/nightly/reference/
Apache License 2.0
1.25k stars 491 forks source link

dont use stdcall on x86_64 where it is not a valid ABI #1600

Closed RalfJung closed 2 months ago

RalfJung commented 2 months ago

Unblocks https://github.com/rust-lang/rust/pull/129935

RalfJung commented 2 months ago

@ehuss any preference which ABI to use here? stdcall is 32bit-only, vectorcall is unstable. We could use "system"?

ehuss commented 2 months ago

As an alternative, you can just change the cfg to be something like cfg(windows) (assuming that is "compatible" for stdcall).

RalfJung commented 2 months ago

That would make it dead code for CI, but yeah that also works.

ehuss commented 2 months ago

That would make it dead code for CI, but yeah that also works.

I think it's fine. It gets tested in rust-lang/rust under windows.