search

rust-lang / rfcbot-rs

Coordinates asynchronous decision making on Rust repositories. Status of tracked issues and PRs can be viewed at https://rfcbot.rs.
https://rfcbot.rs
Apache License 2.0
163 stars 67 forks source link

Include issues already in FCP on user's dashboard #234

Open dtolnay opened 6 years ago

dtolnay commented 6 years ago

Currently rfcbot.rs exposes a convenient list of proposed-FCP issues that I have not signed off yet (https://rfcbot.rs/fcp/dtolnay). But once n-2 team members have signed off and the issue enters FCP, it becomes impossible for me to find through rfcbot.rs.

My concern is of issues on a small team like libs that can quickly receive the threshold number of boxes checked to enter FCP, sometimes within an hour of proposed FCP. Even if my checkbox is no longer required to move the issue into FCP, I still attempt to review every issue involving my team.

I would like to suggest including not just proposed-FCP issues on the user dashboard, but also issues in FCP not yet reviewed by that user. There can be a separate section for these or some other visual indicator so that team members who only ever want to look at proposed-FCP issues can look only at those, while I and team members who would like to get to every issue have a way to find every relevant issue.

If an issue finishes FCP and I still have not acted on it, I am fine with it disappearing from my dashboard at that point.

Centril commented 6 years ago

@dtolnay this seems fairly easy to implement; we could just expand the set to PFCP + FCPed RFCs; doesn't have to be a separate section. I'll see if I can fix this up today.