rust-lang / rfcs

RFCs for changes to Rust
https://rust-lang.github.io/rfcs/
Apache License 2.0
5.89k stars 1.56k forks source link

Updating links for accepted RFCs #2183

Closed ExpHP closed 6 years ago

ExpHP commented 6 years ago

The hardest time to locate the text of an RFC is after it gets merged.

Here's what happens:

Not having found myself on the other side of the "merge" coin all too often, I'm not certain, do the repo maintainers have the ability to edit the PR text and fix the link when they merge? Can this be part of the process?

(Or alternatively, make it a point to put these links in tracking issues?)

nagisa commented 6 years ago

While, yes, it is possible for maintainers to edit RFC text, the rendered link was a informal convention IIRC.

You can see the rendered text by clicking the rendered button on the merged file in the repository.

On Oct 20, 2017 3:04 AM, "Michael Lamparski" notifications@github.com wrote:

The hardest time to locate the text of an RFC is after it gets merged.

Here's what happens:

  • The rendered link in the top post invariably points to the author's fork, because that's where the file originally existed.
  • RFC gets merged.
  • A tracking issue gets created which invariably contains a link to the pull request, but no link to the rendered text.
  • Github presents the author with a shiny button to delete their useless branch.
  • Author clicks the button. 🍹 Ahhh, refreshing.
  • Rendered link is now broken.

Not having found myself on the other side of the "merge" coin all too often, I'm not certain, do the maintainers have the ability to edit the PR text and fix the link when they merge? Can this be part of the process?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rust-lang/rfcs/issues/2183, or mute the thread https://github.com/notifications/unsubscribe-auth/AApc0uJPKJxeFaDOxJjd9sw7MO74wiXyks5st-OjgaJpZM4QABa1 .

scottmcm commented 6 years ago

I made updating the rendered link part of the process in https://github.com/rust-lang-nursery/rust-forge/pull/105.

ExpHP commented 6 years ago

Ah, thanks! I shall close this.