rust-lang / rfcs

RFCs for changes to Rust
https://rust-lang.github.io/rfcs/
Apache License 2.0
5.93k stars 1.57k forks source link

Implement dynamic string interpolation #642

Open steveklabnik opened 9 years ago

steveklabnik commented 9 years ago

Issue by bstrie Wednesday Nov 06, 2013 at 16:55 GMT

For earlier discussion, see https://github.com/rust-lang/rust/issues/10318

This issue was labelled with: B-RFC in the Rust repository


In a perfect world, a minimal quine in Rust would look like this:

fn main(){let S="fn main(){let S={1}{0}{1};println!(S,S,'{1}')}";println!(S,S,'"')}

Sadly, this is impossible. Why? Because println! requires that the first argument not just be static; it must be a string literal.

There are other, non-contrived use cases for dynamic string interpolation; acrichto mentions internationalization as one example.

So what would be involved in implementing dynamic string interpolation?

acrichto mentions (https://botbot.me/mozilla/rust/msg/7556963/) that the current machinery used to parse strings for format! provides an interface that could be reused (std::fmt). But that's only part of the solution.

The first issue is that we can't guarantee type safety for dynamic interpolation (can we???), so the syntax for dynamic format strings might need to be rethought. For now we should probably assume that all arguments to dynamic string interpolation will implement ToStr and just ignore any format string options that aren't for positional or named arguments.

The second issue is that we can't just simply have anything like a simple .format() method on strings, like Python has, since we don't have variadic functions. We'd need to either do something like pass an array of trait objects:

"ab{1}d{0}".format(["e" as ~ToStr, "c" as ~ToStr]);  // gross
dyn_format!("ab{1}d{0}", "e", "c");  // maybe a little less gross

...or use method chaining and generics:

fn push<T: Any>(&mut self, x: T) { self.vec.push(~x as ~Any) }
"ab{1}d{0}".format().push("e").push("c").to_str()  // still kinda gross

(all code examples are just quick sketches, might be overlooking details (and don't worry about naming))

Any thoughts?

mbrubeck commented 7 years ago

The runtime-fmt crate by @SpaceManiac implements versions of format! and other interpolation macros that allow dynamic formatting strings.

strega-nil commented 7 years ago

I would rather allow format_args! to take a constexpr string argument, which would come with better constexpr and less use of macros.

eddyb commented 7 years ago

@ubsan You would at least need variadic generics to pull that off, and then you have the named arguments feature... which I suppose you can encode as Named::<"foo">(&expr) for foo = expr.

strega-nil commented 7 years ago

@eddyb :)

strega-nil commented 7 years ago

@eddyb you don't have to reveal my entire plan :)

mbrubeck commented 7 years ago

See also #543.