search

rust-lang / rust-analyzer

A Rust compiler front-end for IDEs
https://rust-analyzer.github.io/
Apache License 2.0
14.15k stars 1.58k forks source link

Metrics in different units #16671

Open szepeviktor opened 7 months ago

szepeviktor commented 7 months ago

hyper's measured body lowering time is in seconds, all others are in milliseconds.

image

https://rust-analyzer.github.io/metrics/

https://github.com/rust-lang/rust-analyzer/blob/5346002d07d09badaf37949bec68012d963d61fc/crates/rust-analyzer/src/cli/analysis_stats.rs#L954

Forcing milliseconds may resolve this.

Veykril commented 7 months ago

The problem is here, we calculated the appropriate time metric per project, not over all projects in a given metric https://github.com/rust-analyzer/metrics/blob/9b9677afdfd878f48b740196a3cdccc2d5020f5a/script.ts#L113-L126