hir::Semantics is a general cache used to be able to resolve any syntax node to its semantic definition. This is generally slow given the kind of work it does, but quite often we do a lot more work than necessary, populating unnecessary DynMap tables and more importantly, we populate it via parsing, where the parsing happens through direct database calls, even though the Semantics itself caches these. That means for big enough files we can end up with thrashing the LRU cache a fair bit. We should fix that, a related problem is the HasSource trait going through the database instead of Semantics which means we can end up with nodes not cached by Semantics ultimately ending up in panics when it tries to lookup stuff (which has happened in the past).
This will most likely require adding callbacks to some of the hir-def crate APIs to abstract away the parsing (and then add / keep the current APIs as convenience APIs where Semantics won't be involved).
Mostly unrelated, but in the past we used to construct multiple Semantics during the execution of a single request. It might be worth checking whether that's still the case.
hir::Semantics
is a general cache used to be able to resolve any syntax node to its semantic definition. This is generally slow given the kind of work it does, but quite often we do a lot more work than necessary, populating unnecessaryDynMap
tables and more importantly, we populate it via parsing, where the parsing happens through direct database calls, even though theSemantics
itself caches these. That means for big enough files we can end up with thrashing the LRU cache a fair bit. We should fix that, a related problem is theHasSource
trait going through the database instead ofSemantics
which means we can end up with nodes not cached bySemantics
ultimately ending up in panics when it tries to lookup stuff (which has happened in the past).So the things that need to be changed are:
HasSource::source
to take a reference to theSemantics
instead that does the right thing https://github.com/rust-lang/rust-analyzer/blob/062e1b9b81542680afde1aa47fa5316ac5133461/crates/hir/src/has_source.rs#L29This will most likely require adding callbacks to some of the
hir-def
crate APIs to abstract away the parsing (and then add / keep the current APIs as convenience APIs where Semantics won't be involved).