Fix Run lens showing when lenses are disabled

rust-lang / rust-analyzer

A Rust compiler front-end for IDEs

https://rust-analyzer.github.io/

Apache License 2.0

13.62k stars 1.49k forks source link

Fix Run lens showing when lenses are disabled #17177

Closed hermannm closed 2 weeks ago

hermannm commented 2 weeks ago

I have disabled Rust Analyzer lenses in my VSCode settings, but noticed that the Run lens still showed. This surprised me, as the docs for lens.run.enable state that it only applies when lens.enable is set. I then found that where we set LensConfig::run, we don't check lens_enable like for the other settings. We did this previously, so this seems like a regression from refactoring. This PR tries to fix that.

Veykril commented 2 weeks ago

Thanks! @bors r+

bors commented 2 weeks ago

:pushpin: Commit d226527a8c83f564e8a013d615fe488a9ed7360a has been approved by Veykril

It is now in the queue for this repository.

bors commented 2 weeks ago

:hourglass: Testing commit d226527a8c83f564e8a013d615fe488a9ed7360a with merge c80006af57d7ad265184cd63504245e756b690d6...

bors commented 2 weeks ago

:sunny: Test successful - checks-actions Approved by: Veykril Pushing c80006af57d7ad265184cd63504245e756b690d6 to master...