search

rust-lang / rust-analyzer

A Rust compiler front-end for IDEs
https://rust-analyzer.github.io/
Apache License 2.0
13.92k stars 1.54k forks source link

Link formatting issue in message popup #17222

Open sryze opened 2 months ago

sryze commented 2 months ago

Found a minor bug related to the rust-analyzer popup showing when a project doesn't have a Cargo.toml file. See the screenshot below:

vscode-rust-analyzer-popup-bug

It looks like the message is expected to be rendered as Markdown (the linkedProjects link) but it's showing as plain text instead.

rust-analyzer version: (eg. output of "rust-analyzer: Show RA Version" command, accessible in VSCode via Ctrl/⌘+Shift+P) rust-analyzer version: 0.3.1958-standalone (5bf2f85c8 2024-05-09)

rustc version: (eg. output of rustc -V) rustc 1.77.2 (25ef9e3d8 2024-04-09)

editor or extension: (eg. VSCode, Vim, Emacs, etc. For VSCode users, specify your extension version; for users of other editors, provide the distribution if applicable) VS Code

relevant settings: (eg. client settings, or environment variables like CARGO, RUSTC, RUSTUP_HOME or CARGO_HOME)

repository link (if public, optional): (eg. rust-analyzer)

code snippet to reproduce: 

// add your code here
sryze commented 2 months ago

Seems related to https://github.com/rust-lang/rust-analyzer/pull/14366

roife commented 2 months ago

Perhaps it's because VSC doesn't support rendering markdown in messages.

Veykril commented 2 months ago

It does but that part is pasted verbatim from the extension code. We should remove the markdown there as we don't expect other clients to support markdown there currently.