False positive in desering tables to non-table types.

rust-lang / rust-analyzer

A Rust compiler front-end for IDEs

https://rust-analyzer.github.io/

Apache License 2.0

14.05k stars 1.56k forks source link

False positive in desering tables to non-table types. #17659

Open alibektas opened 1 month ago

alibektas commented 1 month ago

https://github.com/rust-lang/rust-analyzer/blob/bd9758bd5d780ab41068aa6e9c3ec0b3d3d593db/crates/rust-analyzer/src/config.rs#L3610-L3612

On our side things look alright. So this may require a deeper look into how toml deserializes things.

Veykril commented 1 month ago

Note that this is valid toml, the reason this ought to error for us is that sysroot is a table, but non-table within sysroot is not and hence we should throw an error/warning there

alibektas commented 1 month ago

Yes I am aware of this. Thanks for making it clear tho.